Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARGV: Deprecate ARGV.git? #7174

Merged
merged 1 commit into from Mar 15, 2020
Merged

ARGV: Deprecate ARGV.git? #7174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions Library/Homebrew/build.rb
View file
Open in desktop
Expand Up @@ -122,7 +122,7 @@ def install
staging.retain! if ARGV.keep_tmp?
formula.patch

if ARGV.git?
if Homebrew.args.git?
system "git", "init"
system "git", "add", "-A"
end
Expand All @@ -131,7 +131,7 @@ def install
puts "Type `exit` to return and finalize the installation."
puts "Install to this prefix: #{formula.prefix}"

if ARGV.git?
if Homebrew.args.git?
puts "This directory is now a git repo. Make your changes and then use:"
puts " git diff | pbcopy"
puts "to copy the diff to the clipboard."
Expand Down
4 changes: 0 additions & 4 deletions Library/Homebrew/extend/ARGV.rb
View file
Open in desktop
Expand Up @@ -35,10 +35,6 @@ def keep_tmp?
include? "--keep-tmp"
end

def git?
flag? "--git"
end

def homebrew_developer?
!ENV["HOMEBREW_DEVELOPER"].nil?
end
Expand Down
2 changes: 1 addition & 1 deletion Library/Homebrew/reinstall.rb
View file
Open in desktop
Expand Up @@ -27,7 +27,7 @@ def reinstall_formula(f, build_from_source: false)
fi.options = options
fi.build_bottle = ARGV.build_bottle?
fi.interactive = Homebrew.args.interactive?
fi.git = ARGV.git?
fi.git = Homebrew.args.git?
fi.link_keg ||= keg_was_linked if keg_had_linked_opt
fi.build_from_source = true if build_from_source
if tab
Expand Down