Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pull: fix head_revision definition. #7409

Merged
merged 1 commit into from Apr 20, 2020
Merged

pull: fix head_revision definition. #7409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 1 addition & 5 deletions Library/Homebrew/dev-cmd/pull.rb
View file
Open in desktop
Expand Up @@ -110,7 +110,7 @@ def pull
old_versions = current_versions_from_info_external(patch_changes[:formulae].first) if is_bumpable
patch_puller.apply_patch

end_revision = head_revision(url)
end_revision = `git rev-parse --short HEAD`.strip

changed_formulae_names = []

Expand Down Expand Up @@ -197,10 +197,6 @@ def check_bumps(patch_changes)
end
end

def head_revision(_url, fetched)
Utils.popen_read("git", "rev-parse", fetched ? "FETCH_HEAD" : "HEAD").strip
end

class PatchPuller
attr_reader :base_url
attr_reader :patch_url
Expand Down