Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump rubocop from 0.82.0 to 0.83.0 in /Library/Homebrew #7551

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions Library/Homebrew/Gemfile.lock
Expand Up @@ -25,7 +25,6 @@ GEM
domain_name (~> 0.5)
i18n (1.8.2)
concurrent-ruby (~> 1.0)
jaro_winkler (1.5.4)
json (2.3.0)
mechanize (2.7.6)
domain_name (~> 0.5, >= 0.5.1)
Expand Down Expand Up @@ -81,8 +80,7 @@ GEM
rspec-support (3.9.3)
rspec-wait (0.0.9)
rspec (>= 3, < 4)
rubocop (0.82.0)
jaro_winkler (~> 1.5.1)
rubocop (0.83.0)
parallel (~> 1.10)
parser (>= 2.7.0.1)
rainbow (>= 2.2.2, < 4.0)
Expand Down
2 changes: 1 addition & 1 deletion Library/Homebrew/cask/cmd.rb
Expand Up @@ -228,7 +228,7 @@ def initialize(path)
end

def run(*)
exec @path, *ARGV[1..-1]
exec @path, *ARGV[1..]
end
end

Expand Down
1 change: 1 addition & 0 deletions Library/Homebrew/cask/cmd/abstract_command.rb
Expand Up @@ -37,6 +37,7 @@ def self.run(*args)
end

attr_accessor :args

private :args=

def initialize(*args)
Expand Down
2 changes: 2 additions & 0 deletions Library/Homebrew/cask/cmd/internal_stanza.rb
Expand Up @@ -33,9 +33,11 @@ class InternalStanza < AbstractInternalCommand
option "--inspect", :inspect, false

attr_accessor :format

private :format, :format=

attr_accessor :stanza

private :stanza, :stanza=

def initialize(*)
Expand Down
5 changes: 0 additions & 5 deletions Library/Homebrew/cask/cmd/list.rb
Expand Up @@ -7,11 +7,6 @@ class List < AbstractCommand
option "--versions", :versions, false
option "--full-name", :full_name, false

option "-l", (lambda do |*|
one = true # rubocop:disable Lint/UselessAssignment
opoo "Option -l is obsolete! Implying option -1."
end)

def run
args.any? ? list : list_installed
end
Expand Down
1 change: 1 addition & 0 deletions Library/Homebrew/download_strategy.rb
Expand Up @@ -23,6 +23,7 @@ def stage

attr_reader :cache, :cached_location, :url
attr_reader :meta, :name, :version, :shutup

private :meta, :name, :version, :shutup

def initialize(url, name, version, **meta)
Expand Down
2 changes: 1 addition & 1 deletion Library/Homebrew/extend/os/linux/hardware/cpu.rb
Expand Up @@ -80,7 +80,7 @@ def flags
# Compatibility with Mac method, which returns lowercase symbols
# instead of strings
def features
@features ||= flags[1..-1].map(&:intern)
@features ||= flags[1..].map(&:intern)
end

%w[aes altivec avx avx2 lm ssse3 sse4_2].each do |flag|
Expand Down
2 changes: 2 additions & 0 deletions Library/Homebrew/formula.rb
Expand Up @@ -126,6 +126,7 @@ class Formula
# The currently active {SoftwareSpec}.
# @see #determine_active_spec
attr_reader :active_spec

protected :active_spec

# A symbol to indicate currently active {SoftwareSpec}.
Expand Down Expand Up @@ -176,6 +177,7 @@ class Formula
# Defaults to true.
# @return [Boolean]
attr_accessor :follow_installed_alias

alias follow_installed_alias? follow_installed_alias

# @private
Expand Down
2 changes: 2 additions & 0 deletions Library/Homebrew/formula_installer.rb
Expand Up @@ -25,6 +25,7 @@ class FormulaInstaller

def self.mode_attr_accessor(*names)
attr_accessor(*names)

private(*names)
names.each do |name|
predicate = "#{name}?"
Expand All @@ -38,6 +39,7 @@ def self.mode_attr_accessor(*names)
attr_reader :formula
attr_accessor :options, :build_bottle
attr_accessor :installed_as_dependency, :installed_on_request, :link_keg

mode_attr_accessor :show_summary_heading, :show_header
mode_attr_accessor :build_from_source, :force_bottle, :include_test
mode_attr_accessor :ignore_deps, :only_deps, :interactive, :git
Expand Down
1 change: 1 addition & 0 deletions Library/Homebrew/keg.rb
Expand Up @@ -184,6 +184,7 @@ def self.all
end

attr_reader :path, :name, :linked_keg_record, :opt_record

protected :path

extend Forwardable
Expand Down
1 change: 1 addition & 0 deletions Library/Homebrew/requirement.rb
Expand Up @@ -151,6 +151,7 @@ class << self
include BuildEnvironment::DSL

attr_reader :env_proc, :build

attr_rw :fatal, :cask, :download

def satisfy(options = nil, &block)
Expand Down
5 changes: 3 additions & 2 deletions Library/Homebrew/rubocops/cask/homepage_matches_url.rb
Expand Up @@ -40,6 +40,7 @@ def on_cask(cask_block)
private

attr_reader :cask_block

def_delegators :cask_block, :cask_node, :toplevel_stanzas,
:sorted_toplevel_stanzas

Expand Down Expand Up @@ -141,10 +142,10 @@ def url_match_homepage?(stanza)
end
home = homepage.downcase
if (split_host = host.split(".")).length >= 3
host = split_host[-2..-1].join(".")
host = split_host[-2..].join(".")
end
if (split_home = homepage.split(".")).length >= 3
home = split_home[-2..-1].join(".")
home = split_home[-2..].join(".")
end
host == home
end
Expand Down
1 change: 1 addition & 0 deletions Library/Homebrew/rubocops/cask/mixin/on_homepage_stanza.rb
Expand Up @@ -19,6 +19,7 @@ def on_cask(cask_block)
private

attr_reader :cask_block

def_delegators :cask_block,
:toplevel_stanzas
end
Expand Down
1 change: 1 addition & 0 deletions Library/Homebrew/rubocops/cask/stanza_grouping.rb
Expand Up @@ -39,6 +39,7 @@ def autocorrect(range)
private

attr_reader :cask_block, :line_ops

def_delegators :cask_block, :cask_node, :toplevel_stanzas

def add_offenses
Expand Down
1 change: 1 addition & 0 deletions Library/Homebrew/rubocops/cask/stanza_order.rb
Expand Up @@ -31,6 +31,7 @@ def autocorrect(stanza)
private

attr_reader :cask_block

def_delegators :cask_block, :cask_node, :toplevel_stanzas,
:sorted_toplevel_stanzas

Expand Down
1 change: 1 addition & 0 deletions Library/Homebrew/rubocops/extend/formula.rb
Expand Up @@ -17,6 +17,7 @@ class FormulaCop < Cop
include RangeHelp

attr_accessor :file_path

@registry = Cop.registry

# This method is called by RuboCop and is the main entry point
Expand Down