Update deprecations

Library/Homebrew/cleanup.rb

@@ -84,7 +84,7 @@ def stale_formula?(scrub)
         return true
       end
 
-      return true if scrub && !formula.installed?
+      return true if scrub && !formula.latest_version_installed?
 
       return true if Utils::Bottles.file_outdated?(formula, self)
 

Library/Homebrew/cli/args.rb

@@ -84,11 +84,7 @@ def formulae
         require "formula"
 
         @formulae ||= (downcased_unique_named - casks).map do |name|
-          if name.include?("/") || File.exist?(name)
-            Formulary.factory(name, spec)
-          else
-            Formulary.find_with_priority(name, spec)
-          end
+          Formulary.factory(name, spec)
         end.uniq(&:name).freeze
       end
 

Library/Homebrew/cli/parser.rb

@@ -359,11 +359,7 @@ def formulae
         named_args.map do |arg|
           next if arg.match?(HOMEBREW_CASK_TAP_CASK_REGEX)
 
-          if arg.include?("/") || arg.end_with?(".tar.gz") || File.exist?(arg)
-            Formulary.factory(arg, spec)
-          else
-            Formulary.find_with_priority(arg.downcase, spec)
-          end
+          Formulary.factory(arg, spec)
         end.compact.uniq(&:name)
       end
     end

Library/Homebrew/cmd/--env.rb

@@ -36,7 +36,6 @@ def __env
     shell = if args.plain?
       nil
     elsif args.shell.nil?
-      # legacy behavior
       :bash unless $stdout.tty?
     elsif args.shell == "auto"
       Utils::Shell.parent || Utils::Shell.preferred

Library/Homebrew/cmd/info.rb

@@ -105,11 +105,7 @@ def print_info
       args.named.each_with_index do |f, i|
         puts unless i.zero?
         begin
-          formula = if f.include?("/") || File.exist?(f)
-            Formulary.factory(f)
-          else
-            Formulary.find_with_priority(f)
-          end
+          Formulary.factory(f)
           if args.analytics?
             Utils::Analytics.formula_output(formula)
           else

Library/Homebrew/cmd/upgrade.rb

@@ -216,7 +216,7 @@ def upgrade_formula(f)
   ensure
     # restore previous installation state if build failed
     begin
-      linked_kegs.each(&:link) unless f.installed?
+      linked_kegs.each(&:link) unless f.latest_version_installed?
     rescue
       nil
     end

Library/Homebrew/compat.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-require "compat/cask/dsl/version"
-require "compat/language/python"
-require "compat/requirements/macos_requirement"
+require "compat/extend/nil"
+require "compat/extend/string"
 require "compat/formula"
+require "compat/language/python"
 require "compat/os/mac" if OS.mac?

Library/Homebrew/compat/extend/nil.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+class NilClass
+  module Compat
+    def chuzzle
+      odeprecated "chuzzle", "chomp.presence"
+    end
+  end
+
+  prepend Compat
+end

Library/Homebrew/compat/extend/string.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+class String
+  module Compat
+    # String.chomp, but if result is empty: returns nil instead.
+    # Allows `chuzzle || foo` short-circuits.
+    def chuzzle
+      odeprecated "chuzzle", "chomp.presence"
+      s = chomp
+      s unless s.empty?
+    end
+  end
+
+  prepend Compat
+end

Library/Homebrew/compat/formula.rb

@@ -3,10 +3,19 @@
 class Formula
   module Compat
     def installed?
-      # odeprecated "Formula#installed?",
-      #             "Formula#latest_version_installed? (or Formula#any_version_installed? )"
+      odeprecated "Formula#installed?",
+                  "Formula#latest_version_installed? (or Formula#any_version_installed? )"
       latest_version_installed?
     end
+
+    def prepare_patches
+      if respond_to?(:patches)
+        active_spec.add_legacy_patches(patches)
+        odeprecated "patches", "patch do"
+      end
+
+      super
+    end
   end
 
   prepend Compat

Library/Homebrew/compat/language/haskell.rb

@@ -5,7 +5,7 @@ module Haskell
     module Cabal
       module Compat
         def cabal_sandbox(options = {})
-          # odeprecated "Language::Haskell::Cabal.cabal_sandbox"
+          odeprecated "Language::Haskell::Cabal.cabal_sandbox"
 
           pwd = Pathname.pwd
           home = options[:home] || pwd
@@ -41,14 +41,14 @@ def cabal_sandbox(options = {})
         end
 
         def cabal_sandbox_add_source(*args)
-          # odeprecated "Language::Haskell::Cabal.cabal_sandbox_add_source"
+          odeprecated "Language::Haskell::Cabal.cabal_sandbox_add_source"
 
           system "cabal", "v1-sandbox", "add-source", *args
         end
 
         def cabal_install(*args)
-          # odeprecated "Language::Haskell::Cabal.cabal_install",
-          #             "cabal v2-install directly with std_cabal_v2_args"
+          odeprecated "Language::Haskell::Cabal.cabal_install",
+                      "cabal v2-install directly with std_cabal_v2_args"
 
           # cabal hardcodes 64 as the maximum number of parallel jobs
           # https://github.com/Homebrew/legacy-homebrew/issues/49509
@@ -64,13 +64,13 @@ def cabal_install(*args)
         end
 
         def cabal_configure(flags)
-          # odeprecated "Language::Haskell::Cabal.cabal_configure"
+          odeprecated "Language::Haskell::Cabal.cabal_configure"
 
           system "cabal", "v1-configure", flags
         end
 
         def cabal_install_tools(*tools)
-          # odeprecated "Language::Haskell::Cabal.cabal_install_tools"
+          odeprecated "Language::Haskell::Cabal.cabal_install_tools"
 
           # install tools sequentially, as some tools can depend on other tools
           tools.each { |tool| cabal_install tool }
@@ -81,8 +81,8 @@ def cabal_install_tools(*tools)
         end
 
         def install_cabal_package(*args, **options)
-          # odeprecated "Language::Haskell::Cabal.install_cabal_package",
-          #             "cabal v2-update directly followed by v2-install with std_cabal_v2_args"
+          odeprecated "Language::Haskell::Cabal.install_cabal_package",
+                      "cabal v2-update directly followed by v2-install with std_cabal_v2_args"
 
           cabal_sandbox do
             cabal_install_tools(*options[:using]) if options[:using]

Library/Homebrew/compat/language/python.rb

@@ -5,6 +5,8 @@ module Python
     class << self
       module Compat
         def rewrite_python_shebang(python_path)
+          odeprecated "Language::Python.rewrite_python_shebang",
+                      "Utils::Shebang.rewrite_shebang and Shebang.python_shebang_rewrite_info(python_path)"
           Pathname.pwd.find do |f|
             Utils::Shebang.rewrite_shebang(Shebang.python_shebang_rewrite_info(python_path), f)
           end

Library/Homebrew/compat/os/mac.rb

@@ -5,7 +5,7 @@ module Mac
     class << self
       module Compat
         def preferred_arch
-          # odeprecated "MacOS.preferred_arch", "Hardware::CPU.arch (or ideally let the compiler handle it)"
+          odeprecated "MacOS.preferred_arch", "Hardware::CPU.arch (or ideally let the compiler handle it)"
           if Hardware::CPU.is_64_bit?
             Hardware::CPU.arch_64_bit
           else
@@ -14,12 +14,12 @@ def preferred_arch
         end
 
         def tcc_db
-          # odeprecated "MacOS.tcc_db"
+          odeprecated "MacOS.tcc_db"
           @tcc_db ||= Pathname.new("/Library/Application Support/com.apple.TCC/TCC.db")
         end
 
         def pre_mavericks_accessibility_dotfile
-          # odeprecated "MacOS.pre_mavericks_accessibility_dotfile"
+          odeprecated "MacOS.pre_mavericks_accessibility_dotfile"
           @pre_mavericks_accessibility_dotfile ||= Pathname.new("/private/var/db/.AccessibilityAPIEnabled")
         end
       end

Library/Homebrew/dev-cmd/audit.rb

@@ -134,19 +134,8 @@ def audit
       end
     end
 
-    created_pr_comment = false
-    if new_formula && !new_formula_problem_lines.empty?
-      begin
-        created_pr_comment = true if GitHub.create_issue_comment(new_formula_problem_lines.join("\n"))
-      rescue *GitHub.api_errors => e
-        opoo "Unable to create issue comment: #{e.message}"
-      end
-    end
-
-    unless created_pr_comment
-      new_formula_problem_count += new_formula_problem_lines.size
-      puts new_formula_problem_lines.map { |s| "  #{s}" }
-    end
+    new_formula_problem_count += new_formula_problem_lines.size
+    puts new_formula_problem_lines.map { |s| "  #{s}" }
 
     total_problems_count = problem_count + new_formula_problem_count
     problem_plural = "#{total_problems_count} #{"problem".pluralize(total_problems_count)}"

Library/Homebrew/dev-cmd/irb.rb

@@ -38,7 +38,7 @@ def irb
 
     if args.examples?
       puts "'v8'.f # => instance of the v8 formula"
-      puts ":hub.f.installed?"
+      puts ":hub.f.latest_version_installed?"
       puts ":lua.f.methods - 1.methods"
       puts ":mpd.f.recursive_dependencies.reject(&:installed?)"
       return

Library/Homebrew/dev-cmd/pr-pull.rb

@@ -60,7 +60,7 @@ def setup_git_environment!
     rescue FormulaUnavailableError
       nil
     else
-      if gnupg.installed?
+      if gnupg.any_version_installed?
         path = PATH.new(ENV.fetch("PATH"))
         path.prepend(gnupg.installed_prefix/"bin")
         ENV["PATH"] = path

Library/Homebrew/dev-cmd/pull.rb

@@ -56,7 +56,7 @@ def pull
         gnupg = Formula["gnupg"]
       rescue FormulaUnavailableError # rubocop:disable Lint/SuppressedException
       else
-        if gnupg.installed?
+        if gnupg.any_version_installed?
           path = PATH.new(ENV.fetch("PATH"))
           path.prepend(gnupg.installed_prefix/"bin")
           ENV["PATH"] = path

Library/Homebrew/extend/pathname.rb

@@ -398,15 +398,6 @@ def ds_store?
     basename.to_s == ".DS_Store"
   end
 
-  # https://bugs.ruby-lang.org/issues/9915
-  if RUBY_VERSION == "2.0.0"
-    prepend Module.new {
-      def inspect
-        super.force_encoding(@path.encoding)
-      end
-    }
-  end
-
   def binary_executable?
     false
   end

Library/Homebrew/extend/string.rb

@@ -2,21 +2,6 @@
 
 require "active_support/core_ext/object/blank"
 
-class String
-  # String.chomp, but if result is empty: returns nil instead.
-  # Allows `chuzzle || foo` short-circuits.
-  # TODO: Deprecate.
-  def chuzzle
-    s = chomp
-    s unless s.empty?
-  end
-end
-
-class NilClass
-  # TODO: Deprecate.
-  def chuzzle; end
-end
-
 # Used by the inreplace function (in `utils.rb`).
 module StringInreplaceExtension
   attr_accessor :errors