Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "formulary: install tap if needed." #7629

Merged
merged 1 commit into from May 22, 2020
Merged

Revert "formulary: install tap if needed." #7629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions Library/Homebrew/formulary.rb
View file
Open in desktop
Expand Up @@ -279,8 +279,6 @@ def get_formula(spec, alias_path: nil)
end

def load_file
tap.install unless tap.installed?

super
rescue MethodDeprecatedError => e
e.issues_url = tap.issues_url || tap.to_s
Expand Down
3 changes: 1 addition & 2 deletions Library/Homebrew/test/formulary_spec.rb
View file
Open in desktop
Expand Up @@ -227,8 +227,7 @@ class Wrong#{described_class.class_s(formula_name)} < Formula
end
end

it "raises an error if the Formula is not available after tapping" do
expect_any_instance_of(Tap).to receive(:install)
it "raises an error if the Formula is not available" do
expect {
described_class.to_rack("a/b/#{formula_name}")
}.to raise_error(TapFormulaUnavailableError)
Expand Down