Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump-formula-pr: fix forking error when formula is guessed from url #7634

Merged
merged 1 commit into from May 23, 2020
Merged

bump-formula-pr: fix forking error when formula is guessed from url #7634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 2 additions & 7 deletions Library/Homebrew/dev-cmd/bump-formula-pr.rb
View file
Open in desktop
Expand Up @@ -118,12 +118,6 @@ def bump_formula_pr

formula = args.formulae.first

if formula
tap_full_name, origin_branch, previous_branch = use_correct_linux_tap(formula)
check_for_duplicate_pull_requests(formula, tap_full_name)
checked_for_duplicates = true
end

new_url = args.url
if new_url && !formula
# Split the new URL on / and find any formulae that have the same URL
Expand Down Expand Up @@ -152,7 +146,8 @@ def bump_formula_pr
end
raise FormulaUnspecifiedError unless formula

check_for_duplicate_pull_requests(formula, tap_full_name) unless checked_for_duplicates
tap_full_name, origin_branch, previous_branch = use_correct_linux_tap(formula)
check_for_duplicate_pull_requests(formula, tap_full_name)

requested_spec, formula_spec = if args.devel?
devel_message = " (devel)"
Expand Down