Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License #7762

Merged
merged 86 commits into from
Jul 1, 2020
Merged

License #7762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
86 commits
Select commit Hold shift + click to select a range
b076852
Add license to formula DSL
whoiswillma Jun 10, 2020
864cc76
Print license information in brew info
whoiswillma Jun 10, 2020
8a6fa73
Merge branch 'license' of https://github.com/MLH-Fellowship/brew into…
lionellloh Jun 12, 2020
c10b6bc
brew audit: Checks if a formula has a spdx license
lionellloh Jun 12, 2020
803f9dd
brew audit: check if license data exists
lionellloh Jun 12, 2020
998ab16
brew audit: Included json gem, does conditional check on github
lionellloh Jun 12, 2020
ff1016b
Modify code to load spdx data once
lionellloh Jun 15, 2020
52c6e5d
Fixed brew style offences
lionellloh Jun 15, 2020
51fb414
create: include license field automatically
lionellloh Jun 15, 2020
ac6ea4d
audit: check if a license field is empty
lionellloh Jun 16, 2020
44aac24
dev-cmd/audit_spec: check if license info exists and if it is a stand…
lionellloh Jun 16, 2020
ba824d9
audit: remove spdx-id as a attr_reader attribute
lionellloh Jun 16, 2020
e8f6e65
dev-cmd/audit_spec: WIP: online mismatch does not return any problems…
lionellloh Jun 16, 2020
03fc6b2
audit_spec: override core-tap attribute in online test
lionellloh Jun 16, 2020
757e276
Merge branch 'license-audit' into license-create
lionellloh Jun 17, 2020
3bfca5b
audit: change location of spdx.json file
lionellloh Jun 17, 2020
0b95f03
audit: fix code review changes
lionellloh Jun 17, 2020
c643777
Merge branch 'license-audit' into license-create
lionellloh Jun 17, 2020
d92f747
create: add license field as parsable arg
lionellloh Jun 17, 2020
2b66968
audit: cosmetic changes
lionellloh Jun 17, 2020
c04b9d1
Merge pull request #8 from MLH-Fellowship/license-audit
lionellloh Jun 17, 2020
f1cd404
Merge branch 'master' into license
lionellloh Jun 17, 2020
12566a7
Merge branch 'license' into license-create
lionellloh Jun 17, 2020
610dfe0
audit: fixed with PR comments. Refactored get_repo_license api call a…
lionellloh Jun 17, 2020
f78d4f4
audit spec: include cases for new formula
lionellloh Jun 17, 2020
7b2e664
Merge branch 'license' into license-create
lionellloh Jun 17, 2020
d084356
create: removed print statement
lionellloh Jun 17, 2020
fcc2f4c
Merge pull request #14 from MLH-Fellowship/license-create
lionellloh Jun 17, 2020
7744f18
Update Library/Homebrew/dev-cmd/audit.rb
lionellloh Jun 18, 2020
eca528c
util github: remove nil as that is already expected behaviour
lionellloh Jun 18, 2020
b08d958
"license id" -> "license"
lionellloh Jun 18, 2020
a0b0c77
audit license: use present instead of blank
lionellloh Jun 18, 2020
b2cccfc
Apply suggestions from code review
lionellloh Jun 18, 2020
4cb22ca
license: update manpages
lionellloh Jun 18, 2020
a589050
Update Library/Homebrew/dev-cmd/audit.rb
lionellloh Jun 18, 2020
4287ea7
remove json from gemfile and modified get_repo_data
lionellloh Jun 18, 2020
fa412f9
audit spec: editted strings to matach audit problem strings
lionellloh Jun 18, 2020
ec23911
Merge branch 'license' of https://github.com/MLH-Fellowship/brew into…
lionellloh Jun 18, 2020
bc28ee0
license: update to new license format
lionellloh Jun 22, 2020
de7edd4
brew update-license-data: checks if it is outdated. If so, save new ver
lionellloh Jun 22, 2020
8d7a9d5
audit: rename spdx_id to spdx_data
lionellloh Jun 22, 2020
e4e55c5
update-license-data: wrote rspec test and added one more parseable arg
lionellloh Jun 22, 2020
127d67e
license: update tests and license checking logic
lionellloh Jun 22, 2020
9845091
Apply suggestions from code review
lionellloh Jun 24, 2020
ac818ec
commit older version to test git command
lionellloh Jun 24, 2020
4832a5a
audit: modified problem statement to match
lionellloh Jun 24, 2020
992a30d
spdx: commit correct version of license data to test exit code
lionellloh Jun 24, 2020
221fd4f
wrong spdx to test exit code output
lionellloh Jun 24, 2020
3f267a8
audit: fix callers to call get_repo_data only if @new_formula
lionellloh Jun 24, 2020
3754170
update-license-data: style fixes
lionellloh Jun 24, 2020
2970abd
spdx.json: new version
lionellloh Jun 24, 2020
fbd5c32
bunch of style fixes
lionellloh Jun 24, 2020
0304545
use File.open instead of Kernel.open
lionellloh Jun 24, 2020
cc994b5
Commit man pages
lionellloh Jun 24, 2020
57fd1fd
Merge branch 'master' into license
lionellloh Jun 25, 2020
97ae608
update internal commands list
lionellloh Jun 25, 2020
22baff3
Apply suggestions from code review
lionellloh Jun 25, 2020
62ffc26
Update man page
lionellloh Jun 25, 2020
eb38890
change back to open because File.open does not work on URLs
lionellloh Jun 25, 2020
5aa0eb4
rename spec file
lionellloh Jun 25, 2020
1b9cbf1
changed method of fetching license data
lionellloh Jun 25, 2020
77a8ff5
single quotes -> double quotes
lionellloh Jun 25, 2020
2cf0ac9
update-spdx-data: use a more specific file path
lionellloh Jun 25, 2020
6a05e36
Remove Homebrew.failed=true
lionellloh Jun 25, 2020
ff7a80e
Merge branch 'master' into license
lionellloh Jun 25, 2020
759708f
Apply suggestions from code review
lionellloh Jun 27, 2020
4d4f6a8
audit: remove unnecessary nil assignment
lionellloh Jun 27, 2020
5f6917a
Merge branch 'master' into license
lionellloh Jun 27, 2020
688a9ad
change .nil? to .blank?
lionellloh Jun 29, 2020
da00713
Apply suggestions from code review
lionellloh Jun 29, 2020
7d4fadc
Update man pages
lionellloh Jun 29, 2020
93d46c6
Pathname::write: allow optional override
lionellloh Jun 29, 2020
074f66f
write .stdout instead of SystemCommand::Result
lionellloh Jun 29, 2020
02bc870
curl: modified curl to allow optional print_stdout
lionellloh Jun 29, 2020
5b3ac1f
update-license-data: modify arguments when calling methods
lionellloh Jun 29, 2020
0ea6245
Revert "Pathname::write: allow optional override"
lionellloh Jun 29, 2020
4dcbe87
update-license-data: use of unlink to remove existing file
lionellloh Jun 29, 2020
da2a426
update-license-data: use curl_download instead of curl
lionellloh Jun 30, 2020
c50f7b8
Revert "curl: modified curl to allow optional print_stdout"
lionellloh Jun 29, 2020
ff95f08
audit test: modified code for reading json file
lionellloh Jun 30, 2020
5b3530b
Apply suggestions from code review
lionellloh Jun 30, 2020
96d60c2
Merge remote-tracking branch 'mlh/license' into license
lionellloh Jun 30, 2020
fb4db63
Merge branch 'master' into license
lionellloh Jun 30, 2020
1422542
components_order and test
lionellloh Jun 30, 2020
57e7e7d
small fix: res -> response
lionellloh Jun 30, 2020
7358dd7
style fixes
lionellloh Jun 30, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,9 @@ jobs:
- name: Run brew man
run: brew man --fail-if-changed

- name: Check for outdated license data
run: brew update-license-data --fail-if-changed

- name: Run brew tests
run: |
# brew tests doesn't like world writable directories
Expand Down
2 changes: 2 additions & 0 deletions Library/Homebrew/cmd/info.rb
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,8 @@ def info_formula(f)

puts "From: #{Formatter.url(github_info(f))}"

puts "License: #{f.license}" if f.license

unless f.deps.empty?
ohai "Dependencies"
%w[build required recommended optional].map do |type|
Expand Down