Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

link_overwrite: allow to overwrite files from alias #7915

Merged
merged 2 commits into from
Jul 6, 2020
Merged

link_overwrite: allow to overwrite files from alias #7915

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5eae33b
link_overwrite: allow to overwrite files from alias
iMichka Jul 5, 2020
17ca752
formula: allow link_overwrite for old name too.
MikeMcQuaid Jul 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions Library/Homebrew/formula.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1112,13 +1112,14 @@ def link_overwrite?(path)
return false if tab_tap.nil?

begin
Formulary.factory(keg.name)
f = Formulary.factory(keg.name)
rescue FormulaUnavailableError
# formula for this keg is deleted, so defer to allowlist
rescue TapFormulaAmbiguityError, TapFormulaWithOldnameAmbiguityError
return false # this keg belongs to another formula
else
return false # this keg belongs to another formula
# this keg belongs to another unrelated formula
return false unless (f.aliases + f.oldname).include?(keg.name)
end
end
to_check = path.relative_path_from(HOMEBREW_PREFIX).to_s
Expand Down