Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of VSCode Extension handling breaks brew bundle cleanup --global for extensions not managed by Homebrew #1211

Closed
philoserf opened this issue May 30, 2023 · 5 comments
Closed

Addition of VSCode Extension handling breaks brew bundle cleanup --global for extensions not managed by Homebrew #1211

philoserf opened this issue May 30, 2023 · 5 comments
Labels
outdated

Comments

@philoserf
Copy link

philoserf commented May 30, 2023 •
edited
Loading

Introduced in #1208

This is surprising and dangerous. It breaks existing workflows.

I count the new behavior as a bug, which should be removed.

See also #1210
@philoserf philoserf changed the title addition of VSCode Extension handling breaks brew bundle cleanup --global for extensions not managed by Homebres Addition of VSCode Extension handling breaks brew bundle cleanup --global for extensions not managed by Homebrew May 30, 2023
@MikeMcQuaid
Copy link
Member

See also #1210

This was already merged. Please don't open issues for things that are already in the process of being fixed and/or already have an open issue.

@philoserf
Copy link
Author

philoserf commented May 30, 2023 •
edited
Loading

Had I known, I wouldn't. It might have landed as I was typing since I did search and browse open and closed issues and pull requests.

@MikeMcQuaid
Copy link
Member

It might have landed as I was typing since I did search and browse open and closed issues and pull requests.

You didn't because you linked to the pull request that closed it literally in this issue when you created it.

@philoserf
Copy link
Author

Oh, yeah. That was an edit—fast work @MikeMcQuaid. Thank you.

@MikeMcQuaid
Copy link
Member

@philoserf You're welcome ❤️

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MikeMcQuaid @philoserf