Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

whatsapp-beta cask incorrect for Apple Silicon #17513

Closed
3 of 6 tasks
alex-ioma opened this issue Aug 23, 2023 · 3 comments
Closed
3 of 6 tasks

whatsapp-beta cask incorrect for Apple Silicon #17513

alex-ioma opened this issue Aug 23, 2023 · 3 comments
Labels

Comments

@alex-ioma
Copy link
Contributor

Verification

Description of issue

When trying to install whatsapp-beta from this tap the version of whatsapp beta is incorrect if you are running a mac with Apple Silicon. I cannot confirm if that applies also to Intel mac and the beta channel has changed location since I did not check.

This is how the formula might be:

cask "whatsapp-beta-native" do
  version "2.23.17.75"
  sha256 :no_check

  url "https://web.whatsapp.com/desktop-beta/mac_native/release... or similar"
  name "WhatsApp"
  desc "Desktop client for WhatsApp"
  homepage "https://www.whatsapp.com/"

  livecheck do
    url "https://web.whatsapp.com/desktop-beta/mac_native/releases... or similar"
    strategy :json do |json|
      json["name"]
    end
  end

  auto_updates true
  conflicts_with cask: [
    "whatsapp",
    "whatsapp-alpha",
    "whatsapp-beta",
  ]

  app "WhatsApp.app"

  zap trash: [
    "~/Library/Application Scripts/net.whatsapp.WhatsApp",
    "~/Library/Application Scripts/net.whatsapp.WhatsApp.Intents",
    "~/Library/Application Scripts/net.whatsapp.WhatsApp.IntentsUI",
    "~/Library/Application Scripts/net.whatsapp.WhatsApp.ServiceExtension",
    "~/Library/Caches/net.whatsapp.WhatsApp",
    "~/Library/Containers/net.whatsapp.WhatsApp",
    "~/Library/Containers/net.whatsapp.WhatsApp.Intents",
    "~/Library/Containers/net.whatsapp.WhatsApp.ServiceExtension",
    "~/Library/Group Containers/group.com.facebook.family",
    "~/Library/Group Containers/group.net.whatsapp.family",
    "~/Library/Group Containers/group.net.whatsapp.WhatsApp.private",
    "~/Library/Group Containers/group.net.whatsapp.WhatsApp.shared",
    "~/Library/Group Containers/group.net.whatsapp.WhatsAppSMB.shared",
    "~/Library/Saved Application State/net.whatsapp.WhatsApp.savedState",
  ]
end

A few doubts:

  • Not sure about the correct url for the dmg file
  • Not sure if this cask should be a different cask or replace the current beta
  • Not sure if ~/Library/Group Containers/group.com.facebook.family should be zapped

Apologies if this is not the right way to report this - I wasn't sure how to properly create a pull request.

Thanks.

Command that failed

brew install --cask whatsapp-beta

Output of command with --verbose --debug

Program installed correctly but is not the latest WhatsApp Beta app for Mac Apple Silicon.

Output of brew doctor and brew config

Not relevant.

Output of brew tap

Not relevant.
@alex-ioma alex-ioma changed the title whatsapp-beta cask not aligned for Apple Silicon whatsapp-beta cask incorrect for Apple Silicon Aug 23, 2023
@bevanjkay
Copy link
Member

I think you're looking for the whatsapp-alpha cask, which links to the new "native" version of whatsapp which is a different branch to the beta of the standard whatsapp cask.

@alex-ioma
Copy link
Contributor Author

Thanks @bevanjkay, you are right! That is the "native beta".

However, by looking at the formula, it looks like the zap sections should be updated. I've just installed the app form the dmg file and the files it creates are as reported in my original posts (cross-checked with AppCleaner).

Would you be able to create a merge request with the updated section or should I?

@bevanjkay
Copy link
Member

Feel free to open a PR to update the zap for the whatsapp-alpha cask 👍🏻

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants