Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blinds #33

Closed
wants to merge 5 commits into from
Closed

Blinds #33

wants to merge 5 commits into from

Conversation

rubencallewaert
Copy link
Collaborator

@rubencallewaert rubencallewaert commented Apr 5, 2021

Finished up support for all type of blinds offered by Niko.
(Direction is indeed an unsolvable issue, we should get in touch with Niko that they add a direction property on their events)
Most of the heavy lifting was already done by @christophevg thanks for that.

Apple homekit detects "moving" as a difference between target and current position.

closes #31

Up to date with master and tested on my own devices.

Depends on my other 2 PR's in the nhc2-hobby-api repo:
homebridge-nhc2/nhc2-hobby-api#17
homebridge-nhc2/nhc2-hobby-api#18

@NielsCorneille
Copy link

Thank you, I have it working locally, would be nice to have it merged.

@wttw
Copy link

wttw commented May 1, 2022

Works nicely for me here, too.

It looks like the pull check build errored due to it using the version of nhc2-hobby-api that doesn't have the Moving attribute added.

@rubencallewaert
Copy link
Collaborator Author

Yes it does work the issue is that I can't publish a new version of nhc2-hobby-api to npm as the travis build isn't working:
homebridge-nhc2/nhc2-hobby-api#26

Unfortunately the maintainer of these two projects does not seem to be active anymore.

I'm considering creating a fork so we can deploy new features again.

@rubencallewaert
Copy link
Collaborator Author

Hi Everyone,

I finally managed to port over both repositories to a new organisation.
The readme files might still be a bit out of date and I'll work on cleaning them up in the future.

You can find the new repository here.

https://github.com/openhomekit/homebridge-nhc2

@christophevg Since you were still active, if you are willing to contribute in the new org, contact me and I'll add you as a contributor.

Please try out the new package (v3.0.0), blinds support should be working there (as good as we can for now).

@christophevg
Copy link
Contributor

Hi @rubencallewaert I'll start with installing/testing/... and we'll see from there.
Nice job, thanks, see you after the blip ;-)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blinds - Motor controls
4 participants