Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: ability to hide Homebridge QR code page element #355

Closed
TimofeyK opened this issue Aug 13, 2019 · 8 comments
Closed

Feature request: ability to hide Homebridge QR code page element #355

TimofeyK opened this issue Aug 13, 2019 · 8 comments

Comments

@TimofeyK
Copy link

The HomeKit code is generally required only once, when adding the Homebridge instance to HomeKit, however the huge QR code is given a permanent prime position on the status page pushing down the actual server status. This is especially annoying when accessing the page from a mobile browser

Is it possible to add a simple toggle in plugin settings that would fold a hide the whole QR code section? Or maybe a show/hide toggle directly on the page that would remember the choice?

I can hide the page element using Safari's content blocking but prefer the native solution

@TimofeyK
Copy link
Author

It would be even more logical from the UI design / usage logic to move the QR code to the Config tab or give it its own tab

@ebaauw
Copy link
Contributor

ebaauw commented Aug 13, 2019

Or: simply hide the QR code when homebridge has been paired to HomeKit. The Bonjour announcement contains this info.

@benfysh
Copy link

benfysh commented Aug 13, 2019

@ebaauw it would be useful to be able to display it when required as some plugins such as homebridge-ring and homebridge-samsung-tizen require you to add devices using the same HomeKit code as Homebridge and it is easier to scan it from another device than manually type it out.

@ebaauw
Copy link
Contributor

ebaauw commented Aug 13, 2019

Does the same QR code work for external accessories? I thought it is specific for the homebridge accessory, as encodes more info that the pin code:
https://github.com/nfarina/homebridge/blob/84b4733ac75aba9e7c19d36be282cd8162077860/lib/server.js#L685

@benfysh
Copy link

benfysh commented Aug 13, 2019

I have just double checked and it works for me, I assume the home app is just pulling the PIN from the QR code?
Image

@ebaauw
Copy link
Contributor

ebaauw commented Aug 13, 2019

Cool. Should work with homebridge-zp's new Television accessories as well, then.

@oznu
Copy link
Member

oznu commented Aug 14, 2019

I've been thinking about hiding the QR code when viewing on a mobile - it's not as if you can make use of the QR code on the same device it's being viewed on.

More generally, I think the whole status page needs a makeover; ideas are welcome 😄.

@stale
Copy link

stale bot commented Sep 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants