Wait for custom UI #1523
Merged
Wait for custom UI #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5912475027
💛 - Coveralls |
donavanbecker
approved these changes
Aug 19, 2023
Merged
donavanbecker
added a commit
that referenced
this pull request
Aug 19, 2023
* Add singular plug-in label (#1458) * Document the default port/address that you can access the UI in your web browser (#1252) * Improve translations (#1459) * Fix capitalization (#1496) * Update zh-CN.json (#1503) * Fixed nested arrays settings (#1504) * Fixed nested arrays settings #2 (#1510) * Fixed nested arrays; Fixed lint; * Removed console.log() * Fixed nested arrays #3 (#1511) * Wait for custom UI (#1522) * Wait for custom UI (#1523) --------- Co-authored-by: Dave Nicolson <david.nicolson@gmail.com> Co-authored-by: Adam Coulombe <adamcoulombe187@hotmail.com> Co-authored-by: Aiden <9078877+aiden0w0@users.noreply.github.com> Co-authored-by: Artem Kononenko <slonick2012@gmail.com>
donavanbecker
added a commit
that referenced
this pull request
Aug 22, 2023
This reverts commit ab2313d.
donavanbecker
added a commit
that referenced
this pull request
Aug 22, 2023
This reverts commit 97ff2c4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
The #1522 fix can sometimes be called too early.
💡 Proposed solution
Set
uiLoadedafter theloadedmessage event.