Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Child Bridge Pin Code #1739

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Add Child Bridge Pin Code #1739

merged 1 commit into from
Nov 18, 2023

Conversation

donavanbecker
Copy link
Contributor

@donavanbecker donavanbecker commented Nov 18, 2023

♻️ Current situation

Currently when you click into the Child Bridge settings for pairing it doesn't show a PIN code.

💡 Proposed solution

This will now display the PIN code so that you can just type in the code. The reason this is useful is because you can actually set different PIN codes per Child bridge within the plugin's _bridge config. Example:


            "_bridge": {
                "name": "Homebridge Child Bridge",
                "manufacturer": "Homebridge Child",
                "model": "Bridge",
                "pin": "123-45-678",
                "username": "0A:B1:23:4C:56:7D",
                "port": 54743
            },
Screenshot 2023-11-18 at 4 14 13 AM Screenshot 2023-11-18 at 3 59 57 AM

⚙️ Release Notes

PIN code is now displayed, under the QR code, when viewing Child Bridge Settings.

➕ Additional Information

If applicable, provide additional context in this section.

Testing

Which tests were added? Which existing tests were adapted/changed? Which situations are covered, and what edge cases are missing?

Reviewer Nudging

Where should the reviewer start? what is a good entry point?

@donavanbecker donavanbecker marked this pull request as ready for review November 18, 2023 10:13
@donavanbecker donavanbecker enabled auto-merge (squash) November 18, 2023 14:44
@donavanbecker donavanbecker merged commit 35eaab7 into homebridge:beta-4.53.0 Nov 18, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants