Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #1736: fix table width, avoid overflow #1741

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

jsiegenthaler
Copy link
Contributor

Refer bug #1736

♻️ Current situation

Table width can exceed 100% of modal window
image

💡 Proposed solution

Limit table width to 100%
image

⚙️ Release Notes

Better display of accessory characteristics should nay have very long values

Testing

None

Reviewer Nudging

Please check my changes :)

@jsiegenthaler jsiegenthaler changed the title Update info-modal.component.html Fix for #1726: Update info-modal.component.html Nov 18, 2023
@jsiegenthaler jsiegenthaler changed the base branch from latest to beta-4.53.0 November 18, 2023 14:52
@jsiegenthaler jsiegenthaler changed the title Fix for #1726: Update info-modal.component.html Fix for #1736: Update info-modal.component.html Nov 18, 2023
@bwp91 bwp91 changed the title Fix for #1736: Update info-modal.component.html Fix for #1736: fix table with, avoid overflow Nov 19, 2023
@bwp91 bwp91 changed the title Fix for #1736: fix table with, avoid overflow Fix for #1736: fix table width, avoid overflow Nov 19, 2023
@bwp91 bwp91 merged commit e633bed into homebridge:beta-4.53.0 Nov 19, 2023
22 checks passed
@jsiegenthaler jsiegenthaler deleted the Fix-for-#1736 branch November 24, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants