Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardise modal footers #1753

Merged
merged 4 commits into from
Nov 20, 2023
Merged

standardise modal footers #1753

merged 4 commits into from
Nov 20, 2023

Conversation

bwp91
Copy link
Contributor

@bwp91 bwp91 commented Nov 20, 2023

these changes are already in alpha branch - part of the work to bring this into the beta.


  • standardise all modal footers to:
    • always show a close button at the bottom
      • show the close button on the left when there is an 'action' button on the right
      • show the close button in the middle when there is no action button
      • all close buttons say 'Close' now rather than varying between close and cancel
  • for varied references of 'Dismiss' and 'Cross click', update all to say 'Dismiss'
  • added missing openFullConfigEditor() function to bridge-plugins-modal.component.ts
  • added new button labels to translation files:
    • form.button_disable
    • form.button_lock
    • form.button_more_info
    • form.button_remove
    • form.button_reset
    • form.button_unlock
  • updated dependencies

@bwp91 bwp91 merged commit f8c68b8 into beta-4.53.0 Nov 20, 2023
26 checks passed
@bwp91 bwp91 deleted the bp/standardise-modal-footers branch November 20, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants