-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar and animation to hamburger menu #1755
Conversation
There are a couple of build issues that will need fixing before this can deploy:
You should get the same result if you run |
I can't be sure but the issue might be on line 52 of |
@bwp91 Thanks. One |
@mkz212 Ready to merge? |
@donavanbecker I won't be anymore! (But I would like to point out that it won't be perfect from start!) |
@donavanbecker Will it be in alpha 6? |
Yes |
@bwp91 @donavanbecker I have to leave now for a few hours. But I see it's not bad. Can you change this? (Just on top of scss changed in this PR). This will solve responive problem:
|
I also see that the Hamburger menu sometimes does not quite work - shows X with the window closed. Only after clicking it jumps in as it should. Probably after clicking on the link class collapsed is not added. Easy to fix. |
What definitely needs to be done:
P.S: Sidebar and menu on mobile It's two separate menus. Sidebar appears on screen >= 992 px, mobile menu on smaller.