Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin card - plugin name #1862

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

mkz212
Copy link
Contributor

@mkz212 mkz212 commented Nov 27, 2023

Hide word "Homebridge" from plugin name (only in plugin card title). Every plugin name starts with "Homebridge"...

@donavanbecker
Copy link
Contributor

What if it is a scoped plugin?

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 28, 2023

@donavanbecker

This change only has an impact on the title displayed on the card.

Currently, it works like this:
If it is filled displayName it displays it. If there is no displayName, it checks the name. Here if it starts with @ it removes everything from @ to the first /. I don't change anything about it - I just hide the Homebridge word and only on the list of plugins - in plugin info and everywhere else it stays as it is.

This does not change the actual name of the plugin.

@donavanbecker donavanbecker merged commit d5ac4fc into homebridge:alpha-4.53.1 Nov 28, 2023
20 checks passed
@donavanbecker donavanbecker added the alpha Related to Alpha Branch label Nov 28, 2023
donavanbecker added a commit that referenced this pull request Nov 28, 2023
@donavanbecker
Copy link
Contributor

@mkz212, I reverted this because of this:
Screenshot 2023-11-27 at 7 58 47 PM
Screenshot 2023-11-27 at 7 58 56 PM
Screenshot 2023-11-27 at 7 59 09 PM
Screenshot 2023-11-27 at 7 59 24 PM

@mkz212 mkz212 deleted the patch-80 branch December 10, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha Related to Alpha Branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants