Plugin card changes #1926
Merged
Plugin card changes #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkz212
commented
Dec 10, 2023
•
mkz212
commented
- Add plugin info to dropdown.
- Move settings just above plugin info.
- Make text also clickable (plugin name, verified, funding, version)
- When update available show version to update instead current.
- Add fade animation to update icon.
- Add bridge icon (on the left of dropdown) when there is recomended bridge, and qr code icon when connect to homekit
- Cog icon notification only when plugin is not configured (update notification moved to update icon, child bridge notification moved to child bridge icon)
- Remove "Homebridge" word from title. It is obvious that the plug is Homebridge.
mkz212
changed the title
mkz212
changed the title
donavanbecker
previously approved these changes
Dec 10, 2023
|
Hi @mkz212 sorry there is now a conflict from the other PR that need fixing! |
|
solved conflicts |
donavanbecker
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.