PluginManager would abort loading plugins when encountering an error #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1491752211
💛 - Coveralls |
ShogunPanda
approved these changes
Nov 22, 2021
|
If we could get this merged and released asap i think this will prevent a lot of grief on the homebridge issues/discord 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
Due to a refactored for-loop, #2915 introduced a regression where the
PluginManager.tswould skip the rest of the plugin list if it encountered an error while loading a plugin.This was due to a forgotten
returnstatement in a previously closure basedforEachloop.💡 Proposed solution
This PR replaces the
returnwith acontinuestatement.⚙️ Release Notes
--
➕ Additional Information
The issue was reported in #3013.
Testing
--
Reviewer Nudging
Easy one.
CC: @ShogunPanda