Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging of Service.AccessoryInformation breaks later updates to it's characteristics #697

Closed
FrodoKenny opened this issue Jul 4, 2016 · 1 comment
Labels

Comments

@FrodoKenny
Copy link

In Server.prototype._createAccessory a potentially supplied AccessoryInformation from the getServices of an Accessory is merged with the default one from the constructor. Because the reference from the constructor is kept instead of the one from getServices, it is not possible to update the Characteristic.Model etc. with a setValue after a callback, using the reference from getServices.

Can it be changed to keep the reference from getServices and merge the default fields into that one?

xdissent added a commit to xdissent/homebridge that referenced this issue Sep 20, 2016
@stale
Copy link

stale bot commented Nov 1, 2017

This issue has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this issue was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant