Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added serialport library as a dependency #357

Merged
merged 1 commit into from Nov 3, 2015
Merged

Conversation

mifi
Copy link
Contributor

@mifi mifi commented Nov 1, 2015

When trying to use the serial port accessory:

Loading 0 platforms...
Loading 1 accessories...
module.js:338
throw err;
^

Error: Cannot find module 'serialport'
at Function.Module._resolveFilename (module.js:336:15)
at Function.Module._load (module.js:286:25)
at Module.require (module.js:365:17)
at require (module.js:384:17)
at Object. (/Users/mifi/Desktop/homebridge/accessories/GenericRS232Device.js:3:18)
at Module._compile (module.js:434:26)
at Object.Module._extensions..js (module.js:452:10)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)
at Module.require (module.js:365:17)

added serialport library as a dependency

@nfarina
Copy link
Contributor

nfarina commented Nov 2, 2015

This dependency was removed because it didn't support the new NodeJS version 4.x. Has it been updated? See #183 for some discussion.

@mifi
Copy link
Contributor Author

mifi commented Nov 3, 2015

Ohh. Well I'm using node v4.1.1 on OSX and can confirm it's working. Don't know about raspberry pi

@nfarina
Copy link
Contributor

nfarina commented Nov 3, 2015

Looks like they fixed the issue: serialport/node-serialport#578

Let's give this a shot.

nfarina added a commit that referenced this pull request Nov 3, 2015
added serialport library as a dependency
@nfarina nfarina merged commit 2df1ebe into homebridge:master Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants