Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shared use of commander between homebridge and UI #3604

Merged
merged 2 commits into from
Apr 27, 2024
Merged

shared use of commander between homebridge and UI #3604

merged 2 commits into from
Apr 27, 2024

Conversation

bwp91
Copy link
Contributor

@bwp91 bwp91 commented Apr 25, 2024 •
edited
Loading

Fixes #3603

@coveralls
Copy link

coveralls commented Apr 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8859876008

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 28.009%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/cli.ts 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/cli.ts 1 0.0%
Totals Coverage Status
Change from base Build 8760537914: -0.02%
Covered Lines: 426
Relevant Lines: 1374
💛 - Coveralls

@bwp91 bwp91 marked this pull request as ready for review April 25, 2024 23:15
@bwp91 bwp91 changed the title beta 1.8.1 shared use of commander between homebridge and the UI repo Apr 25, 2024
@bwp91 bwp91 changed the title shared use of commander between homebridge and the UI repo shared use of commander between homebridge and UI Apr 25, 2024
@bwp91 bwp91 merged commit 828711f into latest Apr 27, 2024
15 checks passed
@bwp91 bwp91 deleted the beta-1.8.1 branch April 27, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donavanbecker donavanbecker donavanbecker approved these changes

@NorthernMan54 NorthernMan54 NorthernMan54 approved these changes

Assignees
No one assigned
Labels
latest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v1.8.0 leads to error when starting homebridge in development environment
4 participants
@bwp91 @coveralls @donavanbecker @NorthernMan54