Add support for Nest platform. #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some things are missing or may not be working correctly but the main things like checking the current temperature, the target temperature, the humidity, setting the target temperature and etc.. I don’t think the current heating mode is correct.
It works but the API doesn’t reflect the change soon enough for HomeKit to be aware it worked. Not sure what to do here.
…ead of global variables.
For now the package location has been changed to reflect this. I've submitted a pull request but it doesn't look like it's been touched in a while so I'm not sure it's going to get merged.
|
This looks awesome and works great for me!! Last piece of my home that wasn't on homebridge 🎅 |
|
I think it's fine to point at your forked nest API until they merge your PR. |
nfarina
added a commit
that referenced
this pull request
Jul 18, 2015
Add support for Nest platform.
|
So it looks like HomeKit thermostats can be set to Celsius or Fahrenheit directly. Notice how in the HomeKit Accessory Simulator you can set the unit type. And in the JSON service info, there's a |
|
Moved last comment to #71. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most support for Nest is here. Some things I've been unable to test, such as the response for the current_schedule_mode because I do not have AC. The responses seem to mirror the output of the target_temperature_type though and can verify the output there should be correct by the results of others taking a look at the nest api. So with any luck the responses from current_schedule_mode should be correct but I cannot verify it. Other things to note, it doesn't seem like the api provides near current updates and for whatever reason HomeKit's automatic conversion to Fahrenheit seems to be off by a smidgen (.5) when comparing the temperature to what's on the thermostat. The module I was using for nest support had to be forked in order to accept setting the thermostat to off so I forked it and the package in the json points to my fix in a repo of mine. Let me know what you think.
[Edit by @nfarina: Fixes #30]