Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homebridge-mqttsmokesensor #573

Closed
mhawkshaw opened this issue Sep 10, 2023 · 7 comments
Closed

homebridge-mqttsmokesensor #573

mhawkshaw opened this issue Sep 10, 2023 · 7 comments
Labels
verified use when a plugin meets the criteria - adds the verified badge text

Comments

@mhawkshaw
Copy link

mhawkshaw commented Sep 10, 2023

Link To GitHub Repo

https://github.com/mhawkshaw/homebridge-mqttsmokesensor

Link To NPM Package

https://www.npmjs.com/package/homebridge-mqttsmokesensor

@mhawkshaw mhawkshaw added the pending the label given to a new verification/icon request label Sep 10, 2023
@github-actions
Copy link

The following pre-checks failed:

❌ Could not determine plugin name.

Comment /check to run checks again.

@mhawkshaw
Copy link
Author

/check

@github-actions
Copy link

✅ Pre-checks completed successfully.

@bwp91
Copy link
Contributor

bwp91 commented Sep 10, 2023

Hi @mhawkshaw

thanks for the request here, happy to verify this plugin 👍

my only input would be somehow managing the logs if there is an issue with the connection, to avoid the error appearing each second in the case of an incorrect config (I appreciate a typical user would not install the plugin if they did not have a device to connect to!)

Screenshot 2023-09-11 at 00 31 17

Maybe it stops trying if it can't connect after a certain amount of times, or the interval only actually logs on every 30th run, or something. I can't pretend I have a good solution here!

@bwp91 bwp91 added reviewed and removed pending the label given to a new verification/icon request labels Sep 10, 2023
@github-actions
Copy link

  • - The plugin must successfully install.
  • - The plugin must implement the Homebridge Plugin Settings GUI.
  • - The plugin must not start unless it is configured.
  • - The plugin must be of type dynamic platform.
  • - The plugin must not offer the same nor less functionality than that of any existing verified plugin.
  • - The plugin must not execute post-install scripts that modify the user's system in any way.
  • - The plugin must not contain any analytics or calls that enable you to track the user.
  • - The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.
  • - The plugin must be published to npm and the source code available on GitHub.
  • - A GitHub release should be created for every new version of your plugin, with patch notes.
  • - The plugin must run on all Active LTS versions of Node.js, at the time of writing this is Node.js v18.
  • - The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
  • - If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.

Everything Looks Good!

@bwp91 bwp91 added verified use when a plugin meets the criteria - adds the verified badge text and removed reviewed labels Sep 10, 2023
@github-actions
Copy link

Congratulations! Your plugin has been verified.

You can now add the Verified by Homebridge badge to your plugin's README:

verified-by-homebridge

[![verified-by-homebridge](https://badgen.net/badge/homebridge/verified/purple)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

Your plugin is now also eligible to display a ❤️ Donate button on its tile in the Homebridge UI. See https://github.com/homebridge/homebridge/wiki/Donation-Links for instructions.

If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along.

Don't forget to join the official Homebridge Discord server, where plugin developers can get tips and advice from other developers and the Homebridge project team in the #plugin-development channel!

Thank you for your contribution to the Homebridge Community.
https://homebridge.io

@mhawkshaw
Copy link
Author

Thanks for the quick turnaround! I've updated the plug-in to limit the number of connection error messages shown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified use when a plugin meets the criteria - adds the verified badge text
Projects
None yet
Development

No branches or pull requests

2 participants