Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homebridge-actron-neo #574

Closed
bwp91 opened this issue Sep 13, 2023 · 8 comments
Closed

homebridge-actron-neo #574

bwp91 opened this issue Sep 13, 2023 · 8 comments
Labels
verified use when a plugin meets the criteria - adds the verified badge text

Comments

@bwp91
Copy link
Contributor

bwp91 commented Sep 13, 2023

Link To GitHub Repo

https://github.com/bstillitano/homebridge-actron-neo

Link To NPM Package

https://www.npmjs.com/package/homebridge-actron-neo

(on behalf of @bstillitano)

@bwp91 bwp91 added the pending the label given to a new verification/icon request label Sep 13, 2023
@github-actions
Copy link

✅ Pre-checks completed successfully.

@bwp91
Copy link
Contributor Author

bwp91 commented Sep 13, 2023

Hi @bstillitano

One thing I would like to suggest is to add some keywords here so that Homebridge UI users can search for say "actron neo" and your plugin comes up!

Also I appreciate 0.0.X versions of plugins probably don't have changes (im referring to your release notes) but please remember that these release notes appear for users in the homebridge UI. The github release notes appear for a user before they update - hence the verification request that a user makes a github release for each version with notes.

So with this in mind please continue to create the github releases, and populate the notes with any important changes to the plugin 👍

But for me all good, happy to verify this plugin, I appreciate the time you spent to rename the plugin so it looks nice in the homebridge UI 👍

@bwp91 bwp91 added the reviewed label Sep 13, 2023
@github-actions
Copy link

  • - The plugin must successfully install.
  • - The plugin must implement the Homebridge Plugin Settings GUI.
  • - The plugin must not start unless it is configured.
  • - The plugin must be of type dynamic platform.
  • - The plugin must not offer the same nor less functionality than that of any existing verified plugin.
  • - The plugin must not execute post-install scripts that modify the user's system in any way.
  • - The plugin must not contain any analytics or calls that enable you to track the user.
  • - The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.
  • - The plugin must be published to npm and the source code available on GitHub.
  • - A GitHub release should be created for every new version of your plugin, with patch notes.
  • - The plugin must run on all Active LTS versions of Node.js, at the time of writing this is Node.js v18.
  • - The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
  • - If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.

Everything Looks Good!

@bwp91 bwp91 added verified use when a plugin meets the criteria - adds the verified badge text and removed pending the label given to a new verification/icon request reviewed labels Sep 13, 2023
@github-actions
Copy link

Congratulations! Your plugin has been verified.

You can now add the Verified by Homebridge badge to your plugin's README:

verified-by-homebridge

[![verified-by-homebridge](https://badgen.net/badge/homebridge/verified/purple)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

Your plugin is now also eligible to display a ❤️ Donate button on its tile in the Homebridge UI. See https://github.com/homebridge/homebridge/wiki/Donation-Links for instructions.

If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along.

Don't forget to join the official Homebridge Discord server, where plugin developers can get tips and advice from other developers and the Homebridge project team in the #plugin-development channel!

Thank you for your contribution to the Homebridge Community.
https://homebridge.io

@bwp91 bwp91 closed this as completed Sep 13, 2023
@bstillitano
Copy link

Hey @bwp91 appreciate the feedback. I'll start to the better populate the release notes and will address the keywords. Thanks for approving this so quickly and for all the help getting it to an approvable state.

@bstillitano
Copy link

Just a follow up @bwp91 , as agreed, keywords and changelogs should be populating properly now for the plugin.

@David-Allen-Arteaga
Copy link

verified-by-homebridge

Details

import "./styles.css";

export default function App() {
return (


Hello CodeSandbox


Start editing to see some magic happen!



);
}

<iframe src="https://codesandbox.io/embed/new?codemirror=1" style="width:100%; height:500px; border:0; border-radius: 4px; overflow:hidden;" allow="accelerometer; ambient-light-sensor; camera; encrypted-media; geolocation; gyroscope; hid; microphone; midi; payment; usb; vr; xr-spatial-tracking" sandbox="allow-forms allow-modals allow-popups allow-presentation allow-same-origin allow-scripts" ></iframe>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified use when a plugin meets the criteria - adds the verified badge text
Projects
None yet
Development

No branches or pull requests

3 participants