Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we warn/prompt when overwriting a file? #32

Closed
homebysix opened this issue Oct 4, 2015 · 3 comments
Closed

Should we warn/prompt when overwriting a file? #32

homebysix opened this issue Oct 4, 2015 · 3 comments
Milestone

Comments

@homebysix
Copy link
Owner

When a png icon file or a recipe already exists in the output directory, should we warn about that? I'm leaning towards no, since I often run Recipe Robot multiple times in a row while making small tweaks, and overwriting existing files is the desired behavior.

If we don't prompt for overwriting, we may want to choose a different default output path than ~/Library/AutoPkg/RecipeOverrides, in order to prevent overwriting existing overrides.

@sheagcraig
Copy link
Collaborator

I guess I'm out of the loop enough that I don't know why we would be writing to RecipeOverrides?

As for overwriting icon files, presumably recipe repos are going to be repos; thus, any changes are going to have to be committed, so a changed icon will be noticed. It's up to the user whether they want to not-include the new icon.

@homebysix
Copy link
Owner Author

I write to RecipeOverrides because it's probably a bad habit I learned early on. What would be a better default? ~/Library/AutoPkg/Recipe Robot?

Agreed on the icon.

@homebysix homebysix modified the milestone: v1.0 Oct 6, 2015
@homebysix
Copy link
Owner Author

Default save location changed to "~/Library/AutoPkg/Recipe Robot output" which should prevent us from overwriting anything except recipes RR previously generated (which is intended).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants