Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error on delete manifest requests where there are no kinds #106

Merged
merged 2 commits into from
Dec 10, 2021
Merged

Error on delete manifest requests where there are no kinds #106

merged 2 commits into from
Dec 10, 2021

Conversation

billiford
Copy link
Collaborator

This is the expected result in OSS Clouddriver - to return a status OK when no kinds are selects.

dmrogers7
dmrogers7 approved these changes Dec 10, 2021
View reviewed changes
Copy link
Collaborator

@dmrogers7 dmrogers7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spinnaker sucks. In the UI, kinds is required for the other two delete by methods, static and dynamic, and them makes it option for labels only to have it turn into a no-op on the backend!

I begrudgingly approve.

@billiford billiford changed the title Ignore delete manifest requests where there are no kinds Error on delete manifest requests where there are no kinds Dec 10, 2021
@dmrogers7 dmrogers7 merged commit 229c8c1 into master Dec 10, 2021
@dmrogers7 dmrogers7 deleted the CN-1164-delete-by-label-no-kinds branch December 10, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmrogers7 dmrogers7 dmrogers7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@billiford @dmrogers7