Errors after unmount component (Android only)

[rapomon]

Hi!

I use react natigation to show the mapboxnavigation in a new screen, after press back button I have several errors in the console, I suppose the mapbox instance should be detroyed correctly before unmount the component.

[Sun Dec 13 2020 10:51:27.812]  ERROR    Mapbox error You're calling `cancelTransitions` after the `MapView` was destroyed, were you invoking it after `onDestroy()`? {"level": "error", "message": "You're calling `cancelTransitions` after the `MapView` was destroyed, were you invoking it after `onDestroy()`?", "tag": "Mbgl-NativeMapView"}
[Sun Dec 13 2020 10:51:27.850]  ERROR    Mapbox error You're calling `jumpTo` after the `MapView` was destroyed, were you invoking it after `onDestroy()`? {"level": "error", "message": "You're calling `jumpTo` after the `MapView` was destroyed, were you invoking it after `onDestroy()`?", "tag": "Mbgl-NativeMapView"}
[Sun Dec 13 2020 10:51:27.883]  ERROR    Mapbox error You're calling `getCameraValues` after the `MapView` was destroyed, were you invoking it after `onDestroy()`? {"level": "error", "message": "You're calling `getCameraValues` after the `MapView` was destroyed, were you invoking it after `onDestroy()`?", "tag": "Mbgl-NativeMapView"}
[Sun Dec 13 2020 10:51:27.907]  WARN     Mapbox warning Style is not fully loaded, not able to get source! {"level": "warning", "message": "Style is not fully loaded, not able to get source!", "tag": "mbgl-locationSymbol"}
[Sun Dec 13 2020 10:51:27.936]  ERROR    Mapbox error You're calling `getMetersPerPixelAtLatitude` after the `MapView` was destroyed, were you invoking it after `onDestroy()`? {"level": "error", "message": "You're calling `getMetersPerPixelAtLatitude` after the `MapView` was destroyed, were you invoking it after `onDestroy()`?", "tag": "Mbgl-NativeMapView"}
[Sun Dec 13 2020 10:51:27.967]  ERROR    Mapbox error You're calling `cancelTransitions` after the `MapView` was destroyed, were you invoking it after `onDestroy()`? {"level": "error", "message": "You're calling `cancelTransitions` after the `MapView` was destroyed, were you invoking it after `onDestroy()`?", "tag": "Mbgl-NativeMapView"}
[Sun Dec 13 2020 10:51:27.998]  ERROR    Mapbox error You're calling `jumpTo` after the `MapView` was destroyed, were you invoking it after `onDestroy()`? {"level": "error", "message": "You're calling `jumpTo` after the `MapView` was destroyed, were you invoking it after `onDestroy()`?", "tag": "Mbgl-NativeMapView"}
[Sun Dec 13 2020 10:51:28.370]  ERROR    Mapbox error You're calling `getCameraValues` after the `MapView` was destroyed, were you invoking it after `onDestroy()`? {"level": "error", "message": "You're calling `getCameraValues` after the `MapView` was destroyed, were you invoking it after `onDestroy()`?", "tag": "Mbgl-NativeMapView"}
[Sun Dec 13 2020 10:51:28.630]  ERROR    Mapbox error You're calling `cancelTransitions` after the `MapView` was destroyed, were you invoking it after `onDestroy()`? {"level": "error", "message": "You're calling `cancelTransitions` after the `MapView` was destroyed, were you invoking it after `onDestroy()`?", "tag": "Mbgl-NativeMapView"}
[Sun Dec 13 2020 10:51:28.900]  ERROR    Mapbox error You're calling `jumpTo` after the `MapView` was destroyed, were you invoking it after `onDestroy()`? {"level": "error", "message": "You're calling `jumpTo` after the `MapView` was destroyed, were you invoking it after `onDestroy()`?", "tag": "Mbgl-NativeMapView"}
[Sun Dec 13 2020 10:51:28.116]  ERROR    Mapbox error You're calling `getCameraValues` after the `MapView` was destroyed, were you invoking it after `onDestroy()`? {"level": "error", "message": "You're calling `getCameraValues` after the `MapView` was destroyed, were you invoking it after `onDestroy()`?", "tag": "Mbgl-NativeMapView"}
[Sun Dec 13 2020 10:51:28.146]  ERROR    Mapbox error You're calling `cancelTransitions` after the `MapView` was destroyed, were you invoking it after `onDestroy()`? {"level": "error", "message": "You're calling `cancelTransitions` after the `MapView` was destroyed, were you invoking it after `onDestroy()`?", "tag": "Mbgl-NativeMapView"}
[Sun Dec 13 2020 10:51:28.177]  ERROR    Mapbox error You're calling `jumpTo` after the `MapView` was destroyed, were you invoking it after `onDestroy()`? {"level": "error", "message": "You're calling `jumpTo` after the `MapView` was destroyed, were you invoking it after `onDestroy()`?", "tag": "Mbgl-NativeMapView"}
[Sun Dec 13 2020 10:51:28.204]  ERROR    Mapbox error You're calling `getCameraValues` after the `MapView` was destroyed, were you invoking it after `onDestroy()`? {"level": "error", "message": "You're calling `getCameraValues` after the `MapView` was destroyed, were you invoking it after `onDestroy()`?", "tag": "Mbgl-NativeMapView"}
[Sun Dec 13 2020 10:51:28.232]  ERROR    Mapbox error You're calling `cancelTransitions` after the `MapView` was destroyed, were you invoking it after `onDestroy()`? {"level": "error", "message": "You're calling `cancelTransitions` after the `MapView` was destroyed, were you invoking it after `onDestroy()`?", "tag": "Mbgl-NativeMapView"}
[Sun Dec 13 2020 10:51:28.263]  ERROR    Mapbox error You're calling `jumpTo` after the `MapView` was destroyed, were you invoking it after `onDestroy()`? {"level": "error", "message": "You're calling `jumpTo` after the `MapView` was destroyed, were you invoking it after `onDestroy()`?", "tag": "Mbgl-NativeMapView"}
[Sun Dec 13 2020 10:51:28.289]  ERROR    Mapbox error You're calling `getCameraValues` after the `MapView` was destroyed, were you invoking it after `onDestroy()`? {"level": "error", "message": "You're calling `getCameraValues` after the `MapView` was destroyed, were you invoking it after `onDestroy()`?", "tag": "Mbgl-NativeMapView"}
[Sun Dec 13 2020 10:51:28.316]  ERROR    Mapbox error You're calling `cancelTransitions` after the `MapView` was destroyed, were you invoking it after `onDestroy()`? {"level": "error", "message": "You're calling `cancelTransitions` after the `MapView` was destroyed, were you invoking it after `onDestroy()`?", "tag": "Mbgl-NativeMapView"}
[Sun Dec 13 2020 10:51:28.350]  ERROR    Mapbox error You're calling `jumpTo` after the `MapView` was destroyed, were you invoking it after `onDestroy()`? {"level": "error", "message": "You're calling `jumpTo` after the `MapView` was destroyed, were you invoking it after `onDestroy()`?", "tag": "Mbgl-NativeMapView"}

[rossmartin]

Thanks for noting this and I'm aware of these logs as of the latest release (0.1.7). The native android view (mapbox NavigationView) is being destroyed and the appropriate mapbox teardown is being done. Prior to this new release there was a lifecycle issue where you could not mount the MapboxNavigation component again after it had been used before.

I tried to get rid of these errors that crop up after destroying the NavigationView but could not figure it out. I think there is a flaw in how the NavigationView shutdown is implemented. If you dig deep enough you'll see that the onDestroy here calls super.onDestroy() (which is the onDestroy of the NavigationView in the SDK because the RN MapboxNavigationView extends it, and there it calls shutdown in that class).

I'll leave this issue open for anyone else that might come across it. It is working as intended despite these errors showing from the native SDK.

[rapomon]

Thank you for the detaile explanation.

Anyway, the application works fine and the app does not crash.

Best regards.

[rossmartin]

Hey I wanted to provide an update on this based on a finding. This will not occur in a release build on android. It only happens when running a debug build and the slowdown appears to be caused by the RN bridge getting flooded with logs.