Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes downloader to get fetch non-empty release #220

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

dalbar
Copy link
Contributor

@dalbar dalbar commented Mar 28, 2022

Adds an additional filter to fetch the latest release with assets.
Fixes the usage in combination with pre-releases that typically do not have assets yet.

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #220 (9650a6b) into main (a5649a8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #220   +/-   ##
=======================================
  Coverage   82.30%   82.30%           
=======================================
  Files          13       13           
  Lines        1260     1260           
=======================================
  Hits         1037     1037           
  Misses        164      164           
  Partials       59       59           
Flag Coverage Δ
unittests 82.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5649a8...9650a6b. Read the comment docs.

@dalbar dalbar marked this pull request as draft March 28, 2022 06:12
@dalbar dalbar force-pushed the fix/non-empty-assets-installer branch 2 times, most recently from 3b8d814 to ea8895d Compare March 28, 2022 06:17
@dalbar dalbar marked this pull request as ready for review March 28, 2022 06:18
scripts/download-latest.sh Outdated Show resolved Hide resolved
Adds an additional filter to fetch the latest release with assets.
Fixes the usage in combination with pre-releases that typically do not
have assets yet.
@dalbar dalbar force-pushed the fix/non-empty-assets-installer branch from ea8895d to 9650a6b Compare March 28, 2022 22:04
@dalbar dalbar requested a review from HeavyWombat March 28, 2022 22:04
Copy link
Member

@HeavyWombat HeavyWombat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HeavyWombat HeavyWombat merged commit 416d58b into homeport:main Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants