Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kubernetes file compare issue with empty documents #224

Merged
merged 2 commits into from
May 19, 2022

Conversation

HeavyWombat
Copy link
Member

@HeavyWombat HeavyWombat commented May 19, 2022

  • Add implicit managedFields exclude
  • Omit empty documents in Kubernetes compare

@dalbar FYI

Add implicit exclude for metadata.managedFields.
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #224 (98392c7) into main (16e0fd6) will increase coverage by 0.29%.
The diff coverage is 95.65%.

❗ Current head 98392c7 differs from pull request most recent head 40ba8c6. Consider uploading reports for the commit 40ba8c6 to get more accurate results

@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
+ Coverage   81.84%   82.14%   +0.29%     
==========================================
  Files          13       13              
  Lines        1289     1305      +16     
==========================================
+ Hits         1055     1072      +17     
  Misses        173      173              
+ Partials       61       60       -1     
Flag Coverage Δ
unittests 82.14% <95.65%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/dyff/core.go 88.12% <95.45%> (+0.14%) ⬆️
internal/cmd/root.go 91.42% <100.00%> (+0.25%) ⬆️
internal/cmd/between.go 86.04% <0.00%> (+4.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16e0fd6...40ba8c6. Read the comment docs.

When comparing multi document files using Kubernetes semantics, omit empty
documents in the list of documents to compare.
@HeavyWombat HeavyWombat changed the title fix/kube compare Fix Kubernetes file compare issue with empty documents May 19, 2022
@HeavyWombat HeavyWombat merged commit 2e6f1c0 into main May 19, 2022
@HeavyWombat HeavyWombat deleted the fix/kube-compare branch May 19, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant