Fix markdown parsing of multiline text #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unify usage of color formating to avoid parsing of markdown in multiline text content that leads to unwanted output rendering. Simplify `dimgray` function to use same style as other color functions. Add test case to verify output is rendered as expected.
With the unified text rendering, the unchanged output is not also colored line by line rather than coloring the line feed character as part of one big color format. Therefore the expected test output is looking slightly different in raw mode.
Codecov Report
@@ Coverage Diff @@
## main #227 +/- ##
==========================================
+ Coverage 82.11% 82.13% +0.01%
==========================================
Files 13 13
Lines 1303 1304 +1
==========================================
+ Hits 1070 1071 +1
Misses 173 173
Partials 60 60
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #225
Follow-up of #226