Fix panic when using --exclude on reports with documents removed
#237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove empty line from recent unit tests to fix test issues.
Create single place to define defaults for report option command line flags to fix inconsistency of the usage of defaults between using `dyff` as a binary versus using the `dyff` code in a test case.
Codecov Report
@@ Coverage Diff @@
## main #237 +/- ##
=======================================
Coverage 82.13% 82.13%
=======================================
Files 13 13
Lines 1304 1304
=======================================
Hits 1071 1071
Misses 173 173
Partials 60 60
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
HeavyWombat
changed the title
--exclude on reports with documents removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from PR #233
Combined commits from PR #233 to fix #232 as well as an internal fix to a inconsistency of the tool defaults, which differed between using
dyffas a standalone binary versus using its core logic in a test case.