Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v5.1.1: fix: use the right export name for the HSTS middleware #40

Merged
merged 2 commits into from
Apr 15, 2020
Merged

v5.1.1: fix: use the right export name for the HSTS middleware #40

merged 2 commits into from
Apr 15, 2020

Conversation

homer0
Copy link
Owner

@homer0 homer0 commented Apr 15, 2020

What does this PR do?

I forgot to push the commit that renamed the HSTS middleware before doing the release, this PR fixes that:

  • HSTSMiddleware -> HSTS
  • hstsMiddleware -> hsts

How should it be tested manually?

Try to import middlewares: { hsts } from jimpex, it shouldn't be undefined; also...

yarn test
# or
npm test

@coveralls
Copy link

coveralls commented Apr 15, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 151

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 148: 0.0%
Covered Lines: 830
Relevant Lines: 830
💛 - Coveralls

@homer0 homer0 merged commit 1b4ebe1 into master Apr 15, 2020
@homer0 homer0 deleted the homer0_fixHSTS branch April 15, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
on:main pr:hotfix pr:version released semver:fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@homer0 @coveralls