Fix the resolve options for a browser target #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I added two extra settings for the
resolve
plugin:browser
: Set totrue
when the target is for browser. Allows the plugin to correctly resolve packages that use thebrowser
key. LikeJimple
.preferBuiltins
: Set totrue
when the target is for Node. It shouldn't try to use native Node modules when the target is for browser.How should it be tested manually?
For
browser
, you can try building a browser target that importsJimple
.For
preferBuiltins
, you can try building a browser target that importsquerystring
.And of course...