Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(services/building/configuration): reduce the configuration params using an event #44

Merged
merged 3 commits into from
Sep 2, 2019

Conversation

homer0
Copy link
Owner

@homer0 homer0 commented Sep 2, 2019

What does this PR do?

Disclaimer: This is a development feature.

This adds a reducer event to reduce the "params" object the plugin uses all across the services to create the configurations.

The idea is that plugins and implementations can make use of this event to modify the information without having to listen for the actual configuration reducers.

It also does a little refactor on the same file where the feature was added in order to escape the complexity rule :P.

How should it be tested manually?

Listen for the new event (and don't forget to return it at then of your listener) and, of course, run the tests:

yarn test
# or
npm test

@coveralls
Copy link

coveralls commented Sep 2, 2019

Pull Request Test Coverage Report for Build 151

  • 20 of 20 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 149: 0.0%
Covered Lines: 1494
Relevant Lines: 1494

💛 - Coveralls

@homer0 homer0 merged commit 9c0c541 into next Sep 2, 2019
@homer0 homer0 deleted the homer0_paramsEvent branch September 2, 2019 04:06
@homer0 homer0 added the on:next label Sep 2, 2019
@homer0 homer0 mentioned this pull request Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants