Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(project): use husky #18

Merged
merged 6 commits into from
Aug 1, 2019
Merged

refactor(project): use husky #18

merged 6 commits into from
Aug 1, 2019

Conversation

homer0
Copy link
Owner

@homer0 homer0 commented Aug 1, 2019

What does this PR do?

It adds husky in order to manage the repository hooks installation and execution.

The PR also:

  • Renames the hooks files.
  • Removes the installation script.
  • Checks if yarn is installed before calling it from the hooks; if is not present, it will use npm.

How should it be tested manually?

Before installing the branch, remove the old hooks:

rm ./.git/hooks/pre-commit && ./.git/hooks/post-merge

Then install the branch (dependencies) and test the hooks:

# It should call the 'lint' and 'test' scripts
./.git/hooks/pre-commit
# It should try to install dependencies
./.git/hooks/post-merge

@coveralls
Copy link

coveralls commented Aug 1, 2019

Pull Request Test Coverage Report for Build 67

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 64: 0.0%
Covered Lines: 52
Relevant Lines: 52

💛 - Coveralls

@homer0 homer0 changed the base branch from homer0_updateDependencies to next August 1, 2019 02:49
@homer0 homer0 merged commit 52c482b into next Aug 1, 2019
@homer0 homer0 deleted the homer0_husky branch August 1, 2019 02:49
@homer0 homer0 added the on:next label Aug 1, 2019
@homer0 homer0 mentioned this pull request Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants