Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SVG loaders for SSR targets #5

Merged
merged 1 commit into from
Apr 2, 2018
Merged

Fix SVG loaders for SSR targets #5

merged 1 commit into from
Apr 2, 2018

Conversation

homer0
Copy link
Owner

@homer0 homer0 commented Apr 2, 2018

What does this PR do?

When a Node target was building a browser target files, it would handle SVG files as both fonts and images, because the RegExp on the loaders are specific to the target being processed.

This fix add listeners for the fonts and images rules in order to include the paths for the SSR targets.

This is a breaking change because I changed a few properties and methods of the main service.

On the next major release I'll make most of the methods and properties private so changes like these won't be breaking, there's no reason to use the service outside the plugin.

How should it be tested manually?

yarn test
# or
npm test

@coveralls
Copy link

Pull Request Test Coverage Report for Build 19

  • 34 of 34 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 17: 0.0%
Covered Lines: 94
Relevant Lines: 94

💛 - Coveralls

@homer0 homer0 merged commit 2133085 into next Apr 2, 2018
@homer0 homer0 deleted the homer0_svg branch April 2, 2018 22:45
@homer0 homer0 added the on:next label Apr 3, 2018
@homer0 homer0 mentioned this pull request Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants