Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the new devServer.open option #43

Merged
merged 2 commits into from
Jul 6, 2018
Merged

Conversation

homer0
Copy link
Owner

@homer0 homer0 commented Jul 6, 2018

What does this PR do?

homer0/projext#50 added a new option to decided whether you want to open the browser or not when running the dev server. This PR implements the new option.

How should it be tested manually?

Since projext hasn't been released yet, you would first need to change its version to homer0/projext#next.

Now, on your project configuration, add a new option on your dev server settings:

...
devServer: {
  ...,
+  open: false,
},
...

If you run your target, it shouldn't open the browser.

And of course:

yarn test
# or
npm test

@coveralls
Copy link

Pull Request Test Coverage Report for Build 158

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 157: 0.0%
Covered Lines: 547
Relevant Lines: 547

💛 - Coveralls

@homer0 homer0 merged commit 4e86092 into next Jul 6, 2018
@homer0 homer0 deleted the homer0_devServerOpen branch July 6, 2018 15:54
@homer0 homer0 added the on:next label Jul 6, 2018
This was referenced Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants