Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(project): implement the new manual Babel polyfill #72

Merged
merged 4 commits into from Jul 31, 2019
Merged

Conversation

homer0
Copy link
Owner

@homer0 homer0 commented Jul 31, 2019

What does this PR do?

This is the implementation of homer0/projext#77.

The package @babel/polyfill has been deprecated in favor of using core-js and regenerator-runtime directly

The project now requires core-js, regenerator-runtime and adds a custom polyfill file that imports them, following the recommandation of @babel/polyfill's deprecation note.

This is breaking beause WebpackConfiguration now requires webpackPluginInfo in order to create the path to the "polyfill" file.

How should it be tested manually?

In order to test this, you need to install homer0/projext#next and make sure you delete the copy of projext npm/yarn will install inside this package's node_modules.

Then run/build your target with babel.polyfill set to true, you should have the new polyfills in place.

Also, don't forget...

yarn test
# or
npm test

@coveralls
Copy link

coveralls commented Jul 31, 2019

Pull Request Test Coverage Report for Build 261

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 258: 0.0%
Covered Lines: 605
Relevant Lines: 605

💛 - Coveralls

@homer0 homer0 changed the base branch from homer0_update to next July 31, 2019 10:11
@homer0 homer0 merged commit 9b76607 into next Jul 31, 2019
@homer0 homer0 added the on:next label Jul 31, 2019
@homer0 homer0 deleted the homer0_polyfill branch July 31, 2019 10:12
@homer0 homer0 mentioned this pull request Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants