Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(services/building/configuration): load targets dotenv files #73

Merged
merged 2 commits into from Jul 31, 2019

Conversation

homer0
Copy link
Owner

@homer0 homer0 commented Jul 31, 2019

What does this PR do?

This is the implementation of homer0/projext#80.

It add supports for targets' .env files.

When creating the definitions that end up on webpack.DefinePlugin, WebpackConfiguration will now include the variables from the .env files.

How should it be tested manually?

In order to test this, you need to install homer0/projext#next and make sure you delete the copy of projext npm/yarn will install inside this package's node_modules.

Create an .env.[target-name] file with a variable declaration and then log it on your target using process.env.[VARIABLE-NAME].

And, of course...

yarn test
# or
npm test

@coveralls
Copy link

coveralls commented Jul 31, 2019

Pull Request Test Coverage Report for Build 263

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 260: 0.0%
Covered Lines: 609
Relevant Lines: 609

💛 - Coveralls

@homer0 homer0 changed the base branch from homer0_polyfill to next July 31, 2019 10:12
@homer0 homer0 merged commit 0c4ae38 into next Jul 31, 2019
@homer0 homer0 added the on:next label Jul 31, 2019
@homer0 homer0 deleted the homer0_dotenv branch July 31, 2019 10:13
@homer0 homer0 mentioned this pull request Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants