Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update project #88

Merged
merged 2 commits into from Dec 29, 2019
Merged

chore: update project #88

merged 2 commits into from Dec 29, 2019

Conversation

homer0
Copy link
Owner

@homer0 homer0 commented Dec 29, 2019

What does this PR do?

  • I updated all the project dependencies to their latest versions.
  • I changed the minimum required Node version to 10.13, as 8 ends LTS next week and raw-loader, file-loader and url-loader latest version require it.

The reason this PR is breaking is, besides the change of the Node version, because raw-loader, file-loader and url-loader no export the parsed content as ESModules, so if you are using commonjs, you'll need to use .default.

How should it be tested manually?

Try the change from commonjs to ESModules for non JS files and, of course, don't forget to...

npm test
# or
yarn test

@coveralls
Copy link

coveralls commented Dec 29, 2019

Pull Request Test Coverage Report for Build 324

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 322: 0.0%
Covered Lines: 654
Relevant Lines: 654

💛 - Coveralls

@homer0 homer0 merged commit 566a077 into next Dec 29, 2019
@homer0 homer0 deleted the homer0_update branch December 29, 2019 05:29
@homer0 homer0 added the on:next label Dec 29, 2019
@homer0 homer0 mentioned this pull request Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants