Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgraded enzyme to v3 (fixes #198) #211

Merged
merged 1 commit into from
Oct 11, 2017

Conversation

pcgilday
Copy link
Contributor

  • Use chai-enzyme@1.0.0-beta.0
  • Added enzyme-adapter-react-15
  • Added react-test-renderer b/c enyzme-adapter-react-15 peer dependency

closes #198

@ghost ghost assigned pcgilday Oct 11, 2017
@ghost ghost added the code review label Oct 11, 2017
@HomeZenBot
Copy link
Member

This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 11, 2017

Codecov Report

Merging #211 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #211   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           6      6           
  Lines          34     35    +1     
=====================================
+ Hits           34     35    +1

@pcgilday
Copy link
Contributor Author

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


a discussion (no related file):
This gets the current tests passing, but is using chai-enzyme@1.0.0-beta.0. I'm not sure if it would be better to wait for chai-enzyme v1 to come out of beta or move forward with the beta version?


Comments from Reviewable

@pcgilday pcgilday assigned SpainTrain and unassigned pcgilday Oct 11, 2017
@SpainTrain
Copy link
Member

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions.


package.json, line 53 at r1 (raw file):

    "cross-env": "~5.0.0",
    "enzyme": "~3.1.0",
    "enzyme-adapter-react-15": "^1.0.1",

tilde!


package.json, line 73 at r1 (raw file):

    "react-addons-test-utils": "~15.6.0",
    "react-dom": "~15.6.1",
    "react-test-renderer": "^15.6.2",

tilde!


Comments from Reviewable

@SpainTrain SpainTrain merged commit e355830 into homezen:master Oct 11, 2017
@ghost ghost removed the code review label Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants