Fix remove button plugin #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- keep the button element inside the 'item' element. - allows to use a custom CSS class for the remove-button element, when settings.mode='single'.
- when removing an item the 'item_remove' event was triggered just with setting.mode 'multi' and not with setting.mode 'single'.
- the remove-button plugin was splitted in two functions (for 'multi' and 'single' mode). This led to divergence in behaviour, fixes, and triggered events (856307c). This commit unifies the code, congruently with the rest of the codebase, making the behaviour again more stable and similar, regardless of the mode (single/multi). - the remove-button plugin, when in 'single' mode, was not able to trigger the 'onDelete' callback, preventing from doing checks on the values; while that was possible just witht he 'multi' mode. Now both modes are able to trigger the callback.
and add an example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I duplicate "my pull request on the original repo"(selectize#1311), since in there the proposed changes are not being merged since years and the library behaviour is incoherent in some scenarios when using it inside the honeybee-agavi-cmf-vendor.
Read the info and links inside that pull request comments, in order to have context and insight about details and the motivations for the proposed changes.
The fork on Honeybee allows to integrate the needed patches, being independent from the original repo updating time.
Remember to check here and integrate new eventual commits from there once every while.