Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: update github actions workflows #17

Merged
merged 6 commits into from
Oct 13, 2023

Conversation

JamieDanielson
Copy link
Contributor

@JamieDanielson JamieDanielson commented Oct 12, 2023

Which problem is this PR solving?

  • With the switch to GitHub Enterprise we introduced stricter permissions at the Org level for GitHub Actions, which disallows the setting for allowing read/write for all scopes. This means we need to manually provide access to individual workflows, at least for private repos. This resulted in some failed action workflows ("Validate PR Title" failed with Error: Resource not accessible by integration)
  • Also, we've renamed the internal actions repo from oss-management-actions to oss-management and the workflow wasn't able to find the redirect at least on private repos, resulting in some failed action workflows ("Apply project labels" failed with Error: Unable to resolve action. Repository not found: honeycombio/oss-management-actions).

Short description of the changes

  • Update the apply-labels.yml workflow to use oss-management
  • Give "write" permissions to apply-labels.yml and validate-pr-title.yml

How to verify that this has the expected result

Successful GHA workflow runs. Note the below comment related to the apply-labels workflow... at any rate this should be in a better state than it was, so I'm not sure how much time to dedicate to looking further into that 馃

@JamieDanielson JamieDanielson requested a review from a team October 12, 2023 18:17
@JamieDanielson JamieDanielson self-assigned this Oct 12, 2023
@JamieDanielson
Copy link
Contributor Author

I think the one error with pull_request_target is failing because it needs to be pull_request, which I've changed. The other error with "Validation failed" might be specifically because of it having problems updating labels that already exist, not sure if it's a real thing or not 馃

@JamieDanielson JamieDanielson added the type: maintenance The necessary chores to keep the dust off. label Oct 12, 2023
Copy link
Collaborator

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of the pull_request on: tardet, look good 馃憤馃徎

@JamieDanielson JamieDanielson merged commit 91f8cfd into main Oct 13, 2023
1 of 2 checks passed
@JamieDanielson JamieDanielson deleted the jamie.add-write-perms-to-gha branch October 13, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance The necessary chores to keep the dust off.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants