Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support classic Ingest Keys #421

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

jharley
Copy link
Contributor

@jharley jharley commented Feb 29, 2024

Which problem is this PR solving?

We've now released Ingest Keys, but in order for them to work with Classic environments properly we need to update the key detection logic.

Short description of the changes

  • Updates the logic of the existing IsClassicKey function to support Classic Ingest Keys
  • upgrades libhoney-go to 1.22.0

@jharley jharley added type: enhancement New feature or request status: blocked version: bump minor A PR that adds behavior, but is backwards-compatible. labels Feb 29, 2024
@jharley jharley requested a review from a team February 29, 2024 18:59
beeline.go Outdated Show resolved Hide resolved
@jharley jharley marked this pull request as ready for review March 4, 2024 15:18
@jharley jharley requested a review from a team as a code owner March 4, 2024 15:18
@MikeGoldsmith MikeGoldsmith merged commit 3b05970 into main Mar 4, 2024
4 checks passed
@MikeGoldsmith MikeGoldsmith deleted the jharley.classic-ingest-key-support branch March 4, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants