-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define Typescript Types #126
Comments
absolutely 👍 |
@allyjweir do you think this will happen or are you blocked by something? (For example time available for free coding.) |
Hey @marcusradell, we had got somewhere with it but never ready for production. Then I changed jobs so no longer working in Typescript so kind of dropped this issue. If you'd like to pick it up then by all means please do! |
Our team would like to request this as well! It's beneficial for Honeycomb API exploration (looking through the documentation vs. seeing directly in the IDE what are the possible configuration options). |
Is anyone working on this? Is it something of interest to the library? I'm willing to prepare a types file from scratch ( or if there is anything already started, continue with it) on my free time (no ETA) |
I've had most of the definitions written some time ago but never had a chance to properly test them. I'll try to open PR soon |
Thanks for getting this out @antonvasin! @vreynolds would we be able to get a new version release so we can start using this? |
When working with
beeline-nodejs
, understanding which functions are available on thebeeline
object imported can require a lot of referring back to the library's implementation.Having done a fair bit of spelunking into the code, I'd be happy to take a pass at writing the initial types. Would this be something that the codebase would be happy to accept?
The text was updated successfully, but these errors were encountered: