add Ruby 3.0 to CI matrix #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're not tracking that over time any more.
Enables the legacy Ruby 2 handling of keyword arguments.
robbkidd
force-pushed
the
robb.add-ruby-3-to-ci
branch
from
a1112de
to
ee5085b
Compare
... which was removed from stdlib in Ruby 3.0. So bring it back for now.
Enables the legacy Ruby 2 handling of keyword arguments.
The last sequel v4 release was in 2017. If someone is still using that version, they're not using Ruby 3.
robbkidd
added
type: maintenance
robbkidd
commented
Sep 15, 2021
| @@ -124,7 +124,7 @@ workflows: | |||
| - lint | |||
| matrix: | |||
| parameters: | |||
| ruby-version: ["2.2", "2.3", "2.4", "2.5", "2.6", "2.7"] | |||
| ruby-version: ["2.2", "2.3", "2.4", "2.5", "2.6", "2.7", "3.0"] | |||
There was a problem hiding this comment.
Note: Ruby 2.2 is included in the test matrix and is the minimum version declared in the gemspec, but the README says Ruby 2.3+ is required. I'm inclined to let it ride for now. I'm sure we'll be dealing with it when we go to move the version constraint on libhoney when the new major version of it releases.
robbkidd
force-pushed
the
robb.add-ruby-3-to-ci
branch
from
6305ec2
to
3a8202d
Compare
The splatting of keywords is handled by the middleware callers.
JamieDanielson
added
version: bump patch
|
Switched back to a patch bump and pending release because of the code changes to client-side integrations. This wasn't only an update to the test suite, so those client-side changes should get released distinctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes