remove CodeCov from test suite #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove the main Gemfile.lock to allow gem versions to float to latest resolveable by gemspec and Ruby version constraints.
Because Gemfile.lock has been removed to allow dependencies to resolve to latest possible, we'll cache dependencies retrieved based on changes to the gemspec instead of the lock file. Good 'nuff.
robbkidd
added
type: maintenance
vreynolds
reviewed
Sep 14, 2021
| require "webmock/rspec" | ||
| require "pry" | ||
|
|
||
| WebMock.disable_net_connect! | ||
|
|
||
| Dir["./spec/support/**/*.rb"].sort.each { |f| require f } | ||
| SimpleCov.formatter = SimpleCov::Formatter::Console | ||
| SimpleCov.formatter = SimpleCov::Formatter::Codecov if SUPPORT_CODECOV |
There was a problem hiding this comment.
why remove this line only?
There was a problem hiding this comment.
It's the line that configures the coverage generating tool (SimpleCov) to use the formatter that sends the report to CodeCov. Without this line, the previous line remains in effect: report current code coverage to STDOUT.
There was a problem hiding this comment.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove CodeCov. (Closes #168.) We're not tracking coverage overtime as much as we used to. SimpleCov is still available to help determine if there is sufficient coverage of a change.
Also remove the main Gemfile.lock (Closes #170.) to allow gem versions to float to latest resolveable by gemspec and Ruby version constraints.