feat: accept both w3c and honeycomb propagation headers by default #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbkidd
added
type: enhancement
robbkidd
changed the title
This is a very simple replacement incoming trace parent propagator hook. It will by default process either a Honeycomb or a W3C trace propagation header. If both are present, which we expect will be a very unusual case, the hook will prefer the Honeycomb trace header.
robbkidd
force-pushed
the
robb.handle-both-hny-and-w3c-trace-prop
branch
from
4391283
to
ac0d9a8
Compare
MikeGoldsmith
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Closes #180
Short description of the changes
This is a very simple replacement incoming trace parent propagator hook. It will by default process either a Honeycomb or a W3C trace propagation header. If both are present, which we expect will be a very unusual case, the hook will prefer the Honeycomb trace header.
TODO